Klaus/gitea-mcp
1
0
Fork 0
Code Issues 12 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

stability: wrap errors with %w instead of %v #1

New Issue
Open
opened 2026-05-23 18:30:00 +00:00 by Klaus · 0 comments
Klaus commented 2026-05-23 18:30:00 +00:00
Owner
Copy Link
Copy Source

Problem

Most fmt.Errorf calls across operation/ wrap errors with %v, which converts them to strings and loses the underlying error type. Callers can't use errors.Is / errors.As to distinguish API failures (404 vs 500), context cancellations, or SDK error types.

Affected files (non-exhaustive):

  • operation/milestone/milestone.go
  • operation/repo/branch.go, operation/repo/release.go, operation/repo/commit.go, operation/repo/file.go, operation/repo/repo.go, operation/repo/tag.go, operation/repo/tree.go
  • operation/label/label.go
  • operation/pull/pull.go
  • operation/wiki/wiki.go
  • operation/issue/issue.go
  • operation/search/search.go
  • operation/timetracking/timetracking.go
  • operation/user/user.go
  • operation/notification/notification.go
  • operation/packages/packages.go
  • pkg/to/to.go

operation/actions/runs.go already does this correctly — good reference.

Suggested direction

Sweep fmt.Errorf(".*%v", err) → fmt.Errorf(".*%w", err). Add a golangci-lint rule (errorlint) to keep new code consistent.

## Problem Most `fmt.Errorf` calls across `operation/` wrap errors with `%v`, which converts them to strings and loses the underlying error type. Callers can't use `errors.Is` / `errors.As` to distinguish API failures (404 vs 500), context cancellations, or SDK error types. Affected files (non-exhaustive): - `operation/milestone/milestone.go` - `operation/repo/branch.go`, `operation/repo/release.go`, `operation/repo/commit.go`, `operation/repo/file.go`, `operation/repo/repo.go`, `operation/repo/tag.go`, `operation/repo/tree.go` - `operation/label/label.go` - `operation/pull/pull.go` - `operation/wiki/wiki.go` - `operation/issue/issue.go` - `operation/search/search.go` - `operation/timetracking/timetracking.go` - `operation/user/user.go` - `operation/notification/notification.go` - `operation/packages/packages.go` - `pkg/to/to.go` `operation/actions/runs.go` already does this correctly — good reference. ## Suggested direction Sweep `fmt.Errorf(".*%v", err)` → `fmt.Errorf(".*%w", err)`. Add a `golangci-lint` rule (`errorlint`) to keep new code consistent.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Klaus
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Klaus/gitea-mcp#1
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?