Klaus/gitea-mcp
1
0
Fork 0
Code Issues 12 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

stability: protect pkg/flag globals from concurrent mutation #4

New Issue
Open
opened 2026-05-23 18:30:16 +00:00 by Klaus · 0 comments
Klaus commented 2026-05-23 18:30:16 +00:00
Owner
Copy Link
Copy Source

Problem

pkg/flag/flag.go exposes mutable package-level variables (Token, Host, Port, Mode, Debug, Insecure, etc.) that are set once at startup but later read concurrently by every tool handler. Tests (e.g. operation/pull/pull_test.go) directly mutate flag.Token, creating data races against any in-flight tool call when go test -race is run alongside the HTTP server.

Suggested direction

Two options:

  1. Lightweight: wrap each global with sync/atomic or a sync.RWMutex and expose Get/Set accessors. Lowest churn.
  2. Cleaner: move config into an immutable Config struct constructed once in cmd/cmd.go and passed via context (matches how the per-request token already flows through pkg/context.TokenContextKey).

Either way: run the test suite with -race in CI to catch regressions.

## Problem `pkg/flag/flag.go` exposes mutable package-level variables (`Token`, `Host`, `Port`, `Mode`, `Debug`, `Insecure`, etc.) that are set once at startup but later read concurrently by every tool handler. Tests (e.g. `operation/pull/pull_test.go`) directly mutate `flag.Token`, creating data races against any in-flight tool call when `go test -race` is run alongside the HTTP server. ## Suggested direction Two options: 1. **Lightweight:** wrap each global with sync/atomic or a `sync.RWMutex` and expose `Get`/`Set` accessors. Lowest churn. 2. **Cleaner:** move config into an immutable `Config` struct constructed once in `cmd/cmd.go` and passed via context (matches how the per-request token already flows through `pkg/context.TokenContextKey`). Either way: run the test suite with `-race` in CI to catch regressions.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Klaus
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Klaus/gitea-mcp#4
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?