Klaus/gitea-mcp
1
0
Fork 0
Code Issues 12 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

stability: redact tokens from logs and error responses #5

New Issue
Open
opened 2026-05-23 18:30:22 +00:00 by Klaus · 0 comments
Klaus commented 2026-05-23 18:30:22 +00:00
Owner
Copy Link
Copy Source

Problem

In debug mode (GITEA_DEBUG=true), pkg/to/to.go and pkg/log log marshalled tool inputs/results. Some tool inputs include an Authorization header pass-through; error bodies from the Gitea SDK can also echo URLs containing the token in query params for older clients. Today there is no sanitizer — a debug log file (~/.gitea-mcp/gitea-mcp.log) shipped from a customer environment could leak credentials.

Suggested direction

  • Add a small redactor in pkg/log that strips Authorization: headers, token=... query params, and anything matching common bearer-token patterns before writing
  • Apply it in both the debug request/response logger and the error-formatting path
  • Add a unit test that feeds a known token through and asserts it is replaced with ***
## Problem In debug mode (`GITEA_DEBUG=true`), `pkg/to/to.go` and `pkg/log` log marshalled tool inputs/results. Some tool inputs include an `Authorization` header pass-through; error bodies from the Gitea SDK can also echo URLs containing the token in query params for older clients. Today there is no sanitizer — a debug log file (`~/.gitea-mcp/gitea-mcp.log`) shipped from a customer environment could leak credentials. ## Suggested direction - Add a small redactor in `pkg/log` that strips `Authorization:` headers, `token=...` query params, and anything matching common bearer-token patterns before writing - Apply it in both the debug request/response logger and the error-formatting path - Add a unit test that feeds a known token through and asserts it is replaced with `***`
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Klaus
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Klaus/gitea-mcp#5
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?